ZA | 25-SDC-July | Luke Manyamazi | Sprint 1 | Can't log in from profile page#51
Open
Luke-Manyamazi wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Conversation
Luke-Manyamazi
added
Needs Review
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This is a cute workaround, but the core of this bug report is that we're showing a component that doesn't work - if you go to http://localhost:8000/index.html#/profile/AS there's a login component that can never work (if you're not logged in).
Ideally we would make the login component work. If we can't do that, we should hide the component.
There are probably other pages that show a login form when you're not logged in, that don't work - there's probably a common underlying pattern here we need to fix.
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions
None